Use aws_s3_object instead of aws_s3_bucket_object #821
Conversation
gjclark
changed the title
NISAR has: terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.0"
}
null = {
source = "hashicorp/null"
version = "~> 2.1"
}
}
}Should I just duplicate that here? Well, actually, I cut out a couple things that were in https://github.com/asfadmin/CIRRUS-NISAR/blob/master/workflows/nisar/provider.tf. |
|
You should only include the providers that the module actually needs and you should use |
| @@ -11,7 +11,6 @@ | |||
|
|
|||
| # Tools | |||
| .terraform | |||
| /terraform/providers.tf | |||
There was a problem hiding this comment.
Lol, why was that in there?
There was a problem hiding this comment.
Hah I don't know. I was hoping to find some discussion in the PR that brought that in. Couldn't find the reason.
terraform/providers.tf
Outdated
| version = ">= 5.0" | ||
| } | ||
| } | ||
| } |
terraform/providers.tf
Outdated
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 5.0" |
There was a problem hiding this comment.
This isn't the minimum. I just checked a random 4.x version and 4.63 has the aws_s3_object already. So you can go down at least to that.
You should find the lowest version that has that resource. I would do it through trial and error using this page and selecting the version from the version dropdown:
https://registry.terraform.io/providers/hashicorp/aws/4.63.0/docs/resources/s3_bucket_object
There was a problem hiding this comment.
Looks like 4.0 introduced it.
gjclark
force-pushed
the
gjc/refactor/aws_s3_object
branch
from
6125c91
to
d0c2d3c
Compare
Closes #801